Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update java version #198

Merged
merged 35 commits into from
Dec 3, 2024
Merged

chore: update java version #198

merged 35 commits into from
Dec 3, 2024

Conversation

yanksyoon
Copy link
Collaborator

@yanksyoon yanksyoon commented Nov 13, 2024 •
edited
Loading

Applicable spec:

Overview

  • Update Java version and Jenkins version to LTS

Rationale

  • Java EOL support for Jenkins
  • Jenkins new LTS release

Juju Events Changes

None

Module Changes

None

Library Changes

Checklist

Some tests are broken due to: canonical/microk8s#4765

@yanksyoon
debug (typo)
75bb8a3
@yanksyoon
fix: rockcraft version
bc9856e
@yanksyoon
update identity bundle versions
e177c03
@yanksyoon
trivy ignore unpatched vuln
ddbc2d6
@yanksyoon
test: use juju 3.5
90c6ed4
@yanksyoon
build command and fix comments
23f1434
@yanksyoon
try manual deploy
defafbb
@yanksyoon
test: public ingress relation jenkins
8a58d02
@yanksyoon
fix: typo & lint
2e026a5
@yanksyoon
test: add oathkeeper relations
a78dd2c
@yanksyoon
test: remove wait for idle before deploy
0ef28f5
@yanksyoon
test: fix: oathkeeper relation fix
ef30be1
@yanksyoon
test: traefik certificates
933646d
@yanksyoon
test: use model.integrate instead of deprecated model.relatet
b8c5f9d
@yanksyoon
test: model wait for idle to get around buggy charms
6a7278d
@yanksyoon
await status code
478f67d
@yanksyoon
fix tests for auth proxy
a69db87
@yanksyoon
fix lint
34dc071
@yanksyoon
fix lint
8af5df9
@yanksyoon
proper auth address
452410e
@yanksyoon
fix: auth proxy test
fc9e56a
@yanksyoon
test: fix thinbackup plugin request
1d84578
@yanksyoon
remove debug
49e2a2e
@yanksyoon
fix type hint
2ce7c1a
@yanksyoon
split plugins test
684bafe
@yanksyoon
try 1.29 microk8s
41c39e6
@yanksyoon
debug
f4759cb
@yanksyoon
kubeconfig dir & debug log
7d6f083
@yanksyoon
Copy link
Collaborator Author

Currently the auth_proxy integration tests are broken due to: canonical/microk8s#4765

@yanksyoon yanksyoon marked this pull request as ready for review December 2, 2024 14:41
@yanksyoon yanksyoon requested a review from a team as a code owner December 2, 2024 14:41
yanksyoon
yanksyoon commented Dec 2, 2024
View reviewed changes
Copy link
Collaborator Author

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments to facilitate reviews

tests/integration/conftest.py Show resolved Hide resolved
tests/integration/conftest.py Show resolved Hide resolved
tests/integration/helpers.py Show resolved Hide resolved
tests/integration/test_auth_proxy.py Show resolved Hide resolved
tests/integration/test_plugins_part_1.py Show resolved Hide resolved
tests/integration/test_plugins_part_2.py Show resolved Hide resolved
tox.ini Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Test coverage for ecdf97c

Name                Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------
src/actions.py         29      0      4      0   100%
src/agent.py          119      0     20      0   100%
src/auth_proxy.py      52      0      8      0   100%
src/charm.py           89      0     10      0   100%
src/cos.py             20      0      0      0   100%
src/ingress.py         16      0      4      0   100%
src/jenkins.py        377      0     50      0   100%
src/pebble.py          25      0      0      0   100%
src/state.py          109      0     16      0   100%
src/timerange.py       30      0      4      0   100%
---------------------------------------------------------------
TOTAL                 866      0    116      0   100%

Static code analysis report

Run started:2024-12-02 14:48:19.206893

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 7617
  Total lines skipped (#nosec): 6
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@yanksyoon yanksyoon added the trivial This is a trivial PR label Dec 2, 2024
@yanksyoon yanksyoon merged commit 06b0999 into main Dec 3, 2024
28 checks passed
@yanksyoon yanksyoon deleted the chore/update-java-version branch December 3, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arturo-seijas arturo-seijas arturo-seijas approved these changes

@weiiwang01 weiiwang01 weiiwang01 approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync trivial This is a trivial PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yanksyoon @weiiwang01 @arturo-seijas